Modernize DECREF (part 1). #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nrnhines
reviewed
Nov 13, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3203 +/- ##
==========================================
- Coverage 67.07% 67.07% -0.01%
==========================================
Files 569 569
Lines 111206 111205 -1
==========================================
- Hits 74592 74591 -1
Misses 36614 36614 ☔ View full report in Codecov by Sentry. |
|
✔️ 6ebacc6 -> Azure artifacts URL |
mgeplf
reviewed
Nov 14, 2024
alkino
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize several occurrences of
Py_DECREFby using nanobind. Using nanobind ensures correct reference counting not only on C-style error paths, but also for C++-style error paths (exceptions).